netdev - Re: [PATCH] net: rds: don't hold sock lock when cancelling work from rds_tcp_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166478041523.16664.6828494970350493146.git-patchwork-notify@kernel.org>
Date:   Mon, 03 Oct 2022 07:00:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:     santosh.shilimkar@...cle.com, davem@...emloft.net,
        sowmini.varadhan@...cle.com, hdanton@...a.com,
        syzkaller-bugs@...glegroups.com,
        syzbot+78c55c7bc6f66e53dce2@...kaller.appspotmail.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] net: rds: don't hold sock lock when cancelling work from
 rds_tcp_reset_callbacks()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Thu, 29 Sep 2022 00:25:37 +0900 you wrote:
> syzbot is reporting lockdep warning at rds_tcp_reset_callbacks() [1], for
> commit ac3615e7f3cffe2a ("RDS: TCP: Reduce code duplication in
> rds_tcp_reset_callbacks()") added cancel_delayed_work_sync() into a section
> protected by lock_sock() without realizing that rds_send_xmit() might call
> lock_sock().
> 
> We don't need to protect cancel_delayed_work_sync() using lock_sock(), for
> even if rds_{send,recv}_worker() re-queued this work while __flush_work()
>  from cancel_delayed_work_sync() was waiting for this work to complete,
> retried rds_{send,recv}_worker() is no-op due to the absence of RDS_CONN_UP
> bit.
> 
> [...]

Here is the summary with links:
  - net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()
    https://git.kernel.org/netdev/net/c/a91b750fd662

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html