netdev - Re: [PATCH net-next v2 4/6] net: microchip: sparx5: add support for apptrust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yzqc85mqkuakokCE@DEN-LT-70577>
Date:   Mon, 3 Oct 2022 08:17:30 +0000
From:   <Daniel.Machon@...rochip.com>
To:     <petrm@...dia.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <maxime.chevallier@...tlin.com>, <thomas.petazzoni@...tlin.com>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <Lars.Povlsen@...rochip.com>, <Steen.Hegelund@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>, <joe@...ches.com>,
        <linux@...linux.org.uk>, <Horatiu.Vultur@...rochip.com>,
        <Julia.Lawall@...ia.fr>, <vladimir.oltean@....com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v2 4/6] net: microchip: sparx5: add support for
 apptrust

> >> > Make use of set/getapptrust() to implement per-selector trust and trust
> >> > order.
> >> >
> >> > Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>
> >> > ---
> >> >  .../ethernet/microchip/sparx5/sparx5_dcb.c    | 116 ++++++++++++++++++
> >> >  .../ethernet/microchip/sparx5/sparx5_main.h   |   3 +
> >> >  .../ethernet/microchip/sparx5/sparx5_port.c   |   4 +-
> >> >  .../ethernet/microchip/sparx5/sparx5_port.h   |   2 +
> >> >  .../ethernet/microchip/sparx5/sparx5_qos.c    |   4 +
> >> >  5 files changed, 127 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > index db17c124dac8..10aeb422b1ae 100644
> >> > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_dcb.c
> >> > @@ -8,6 +8,22 @@
> >> >
> >> >  #include "sparx5_port.h"
> >> >
> >> > +static const struct sparx5_dcb_apptrust {
> >> > +     u8 selectors[256];
> >> > +     int nselectors;
> >> > +     char *names;
> >>
> >> I think this should be just "name".
> >
> > I dont think so. This is a str representation of all the selector values.
> > "names" makes more sense to me.
> 
> But it just points to one name, doesn't it? The name of this apptrust
> policy...

It points to a str of space-separated selector names.
I inteded it to be a str repr. of the selector values, and not a str
identifier of the apptrust policy. Maybe sel(ector)_names?

> 
> BTW, I think it should also be a const char *.

Ack.

> 
> >> > +} *apptrust[SPX5_PORTS];
> >> > +
> >> > +/* Sparx5 supported apptrust configurations */
> >> > +static const struct sparx5_dcb_apptrust apptrust_conf[4] = {
> >> > +     /* Empty *must* be first */
> >> > +     { { 0                         }, 0, "empty"    },
> >> > +     { { IEEE_8021QAZ_APP_SEL_DSCP }, 1, "dscp"     },
> >> > +     { { DCB_APP_SEL_PCP           }, 1, "pcp"      },
> >> > +     { { IEEE_8021QAZ_APP_SEL_DSCP,
> >> > +         DCB_APP_SEL_PCP           }, 2, "dscp pcp" },
> >> > +};
> >> > +