lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YzyAADoHpExvo6XE@shell.armlinux.org.uk> Date: Tue, 4 Oct 2022 19:48:32 +0100 From: "Russell King (Oracle)" <linux@...linux.org.uk> To: Sean Anderson <sean.anderson@...o.com> Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Madalin Bucur <madalin.bucur@....com>, Camelia Alexandra Groza <camelia.groza@....com>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "linuxppc-dev @ lists . ozlabs . org" <linuxppc-dev@...ts.ozlabs.org> Subject: Re: [PATCH net-next v6 6/9] net: dpaa: Convert to phylink On Fri, Sep 30, 2022 at 04:09:30PM -0400, Sean Anderson wrote: > +static void memac_validate(struct phylink_config *config, > + unsigned long *supported, > + struct phylink_link_state *state) > +{ > + __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, }; > + struct fman_mac *memac = fman_config_to_mac(config)->fman_mac; > + > + phylink_generic_validate(config, supported, state); > + > + if (phy_interface_mode_is_rgmii(state->interface) && > + memac->rgmii_no_half_duplex) { > + phylink_caps_to_linkmodes(mask, MAC_10HD | MAC_100HD); > + linkmode_andnot(supported, supported, mask); > + linkmode_andnot(state->advertising, state->advertising, mask); > + } > +} Having been through the rest of this with a fine tooth comb, nothing else stands out with the exception of the above, which I think could be done better with this patch: http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=net-queue&id=e65a47c4053255bd51715d5550e21c869971258c Since the above would become: static void memac_validate(struct phylink_config *config, unsigned long *supported, struct phylink_link_state *state) { struct mac_device *mac_dev = fman_config_to_mac(config); struct fman_mac *memac = mac_dev->fman_mac; unsigned long caps; caps = mac_dev->phylink_config.capabilities; if (phy_interface_mode_is_rgmii(state->interface) && memac->rgmii_no_half_duplex) caps &= ~(MAC_10HD | MAC_100HD); phylink_validate_mask_caps(supported, state, caps); } If you want to pick up my patch that adds this helper into your series, please do. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists