netdev - Re: [PATCH net-next] eth: pse: add missing static inlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Oct 2022 06:51:08 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, kernel test robot <lkp@...el.com>,
        linux@...pel-privat.de, andrew@...n.ch, bagasdotme@...il.com
Subject: Re: [PATCH net-next] eth: pse: add missing static inlines

On Mon, Oct 03, 2022 at 09:03:27PM -0700, Jakub Kicinski wrote:
> build bot reports missing 'static inline' qualifiers in the header.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 18ff0bcda6d1 ("ethtool: add interface to interact with Ethernet Power Equipment")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!

> ---
> CC: linux@...pel-privat.de
> CC: andrew@...n.ch
> CC: bagasdotme@...il.com
> CC: lkp@...el.com
> ---
>  include/linux/pse-pd/pse.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h
> index fd1a916eeeba..fb724c65c77b 100644
> --- a/include/linux/pse-pd/pse.h
> +++ b/include/linux/pse-pd/pse.h
> @@ -110,16 +110,16 @@ static inline void pse_control_put(struct pse_control *psec)
>  {
>  }
>  
> -int pse_ethtool_get_status(struct pse_control *psec,
> -			   struct netlink_ext_ack *extack,
> -			   struct pse_control_status *status)
> +static inline int pse_ethtool_get_status(struct pse_control *psec,
> +					 struct netlink_ext_ack *extack,
> +					 struct pse_control_status *status)
>  {
>  	return -ENOTSUPP;
>  }
>  
> -int pse_ethtool_set_config(struct pse_control *psec,
> -			   struct netlink_ext_ack *extack,
> -			   const struct pse_control_config *config)
> +static inline int pse_ethtool_set_config(struct pse_control *psec,
> +					 struct netlink_ext_ack *extack,
> +					 const struct pse_control_config *config)
>  {
>  	return -ENOTSUPP;
>  }
> -- 
> 2.37.3
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |