netdev - RE: [PATCH net] net: phy: micrel: Fixes FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Oct 2022 06:28:44 +0000
From:   <Divya.Koppera@...rochip.com>
To:     <kuba@...nel.org>
CC:     <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH net] net: phy: micrel: Fixes FIELD_GET assertion

Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, October 4, 2022 5:39 AM
> To: Divya Koppera - I30481 <Divya.Koppera@...rochip.com>
> Cc: andrew@...n.ch; hkallweit1@...il.com; linux@...linux.org.uk;
> davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; UNGLinuxDriver
> <UNGLinuxDriver@...rochip.com>
> Subject: Re: [PATCH net] net: phy: micrel: Fixes FIELD_GET assertion
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Mon, 3 Oct 2022 12:01:30 +0530 Divya Koppera wrote:
> > FIELD_GET() must only be used with a mask that is a compile-time
> > constant. Mark the functions as __always_inline to avoid the problem.
> >
> > Fixes: 21b688dabecb6a ("net: phy: micrel: Cable Diag feature for
> > lan8814 phy")
> 
> Does not apply cleanly to net, please rebase & resend.

I generated patch on net-next, as it is fix I kept for net. When I tried to apply these changes on net, this is getting failed as this main patch(21b688dabecb6a) did not go in net. Shall I resend patch for net-next?

Thanks,
Divya