netdev - Re: doc warnings in *80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62b8bf6f739d1e6e0320864ed0660c9c52b767c4.camel@sipsolutions.net>
Date:   Tue, 04 Oct 2022 09:51:07 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linux-wireless@...r.kernel.org
Subject: Re: doc warnings in *80211

Hi,

> doing basic sanity checks before submitting the net-next PR I spotted
> that we have these warnings when building documentation on net-next:
> 
> Documentation/driver-api/80211/cfg80211:48: ./include/net/cfg80211.h:6960: WARNING: Duplicate C declaration, also defined at driver-api/80211/cfg80211:6924.
> Declaration is '.. c:function:: void cfg80211_rx_assoc_resp (struct net_device *dev, struct cfg80211_rx_assoc_resp *data)'.

Hmm. That's interesting. I guess it cannot distinguish between the type
of identifier?

struct cfg80211_rx_assoc_resp vs. cfg80211_rx_assoc_resp()

Not sure what do about it - rename one of them?

> Documentation/driver-api/80211/mac80211:109: ./include/net/mac80211.h:5046: WARNING: Duplicate C declaration, also defined at driver-api/80211/mac80211:1065.
> Declaration is '.. c:function:: void ieee80211_tx_status (struct ieee80211_hw *hw, struct sk_buff *skb)'.

Same here actually!

I don't think either of these is new.

johannes