netdev - Re: [PATCH RESEND v3 net 3/5] tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221004145524.32829-1-kuniyu@amazon.com>
Date:   Tue, 4 Oct 2022 07:55:24 -0700
From:   Kuniyuki Iwashima <kuniyu@...zon.com>
To:     <pabeni@...hat.com>
CC:     <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <syzkaller-bugs@...glegroups.com>, <vyasevic@...hat.com>,
        <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH RESEND v3 net 3/5] tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().

From:   Paolo Abeni <pabeni@...hat.com>
Date:   Tue, 04 Oct 2022 12:21:20 +0200
> Hello,
> 
> On Mon, 2022-10-03 at 08:44 -0700, Kuniyuki Iwashima wrote:
> [...]
> > @@ -1723,7 +1736,7 @@ struct proto udpv6_prot = {
> >  	.connect		= ip6_datagram_connect,
> >  	.disconnect		= udp_disconnect,
> >  	.ioctl			= udp_ioctl,
> > -	.init			= udp_init_sock,
> > +	.init			= udpv6_init_sock,
> >  	.destroy		= udpv6_destroy_sock,
> >  	.setsockopt		= udpv6_setsockopt,
> >  	.getsockopt		= udpv6_getsockopt,
> 
> It looks like even UDPv6 lite can be ADDRFORMed to ipv4, so I guess we
> need a similar chunk for udplitev6_prot? With that we can unexport 
> udp_init_sock, I guess.

Good catch!
Yes, I'll add that changes in v4.
Thank you.