netdev - Re: [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221005063643.GB14757@pengutronix.de>
Date:   Wed, 5 Oct 2022 08:36:43 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Oleksij Rempel <linux@...pel-privat.de>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: pse-pd: PSE_REGULATOR should depend on REGULATOR

On Tue, Oct 04, 2022 at 06:23:53PM +0200, Geert Uytterhoeven wrote:
> The Regulator based PSE controller driver relies on regulator support to
> be enabled.  If regulator support is disabled, it will still compile
> fine, but won't operate correctly.
> 
> Hence add a dependency on REGULATOR, to prevent asking the user about
> this driver when configuring a kernel without regulator support.
> 
> Fixes: 66741b4e94ca7bb1 ("net: pse-pd: add regulator based PSE driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!

> ---
>  drivers/net/pse-pd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig
> index 73d163704068ac27..687dec49c1e13fa0 100644
> --- a/drivers/net/pse-pd/Kconfig
> +++ b/drivers/net/pse-pd/Kconfig
> @@ -14,6 +14,7 @@ if PSE_CONTROLLER
>  
>  config PSE_REGULATOR
>  	tristate "Regulator based PSE controller"
> +	depends on REGULATOR || COMPILE_TEST
>  	help
>  	  This module provides support for simple regulator based Ethernet Power
>  	  Sourcing Equipment without automatic classification support. For
> -- 
> 2.25.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |