lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Oct 2022 17:14:06 -0700 From: Peilin Ye <yepeilin.cs@...il.com> To: Eric Dumazet <edumazet@...gle.com> Cc: "David S. Miller" <davem@...emloft.net>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Peilin Ye <peilin.ye@...edance.com>, Cong Wang <cong.wang@...edance.com>, netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] net/sock: Introduce trace_sk_data_ready() On Thu, Sep 29, 2022 at 09:19:34AM -0700, Eric Dumazet wrote: > I would rather split this in two parts. > > First patch adding and using a common helper. > > static inline void sock_data_ready(struct sock *sk) > { > sk->sk_data_ready(sk); > } > > s/sk->sk_data_ready(sk)/sock_data_ready(sk)/ > > > Second patch adding the tracing point once in the helper ? > > Alternatively, why not add the tracepoint directly in the called > functions (we have few of them), > instead of all call points ? Thanks for the suggestions. I will move this tracepoint into callees in v2. Thanks, Peilin Ye
Powered by blists - more mailing lists