netdev - Re: [PATCH net 1/2] Revert "net/ieee802154: reject zero-sized raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f77669d-7238-b1f8-a37c-302e68a8962a@datenfreihafen.org>
Date:   Wed, 5 Oct 2022 12:57:19 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Alexander Aring <aahringo@...hat.com>,
        penguin-kernel@...ove.sakura.ne.jp
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux-wpan@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] Revert "net/ieee802154: reject zero-sized
 raw_sendmsg()"

Hello.

On 05.10.22 03:47, Alexander Aring wrote:
> This reverts commit 3a4d061c699bd3eedc80dc97a4b2a2e1af83c6f5.
> 
> There is a v2 which does return zero if zero length is given.
> 
> Signed-off-by: Alexander Aring <aahringo@...hat.com>
> ---
>   net/ieee802154/socket.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c
> index cbd0e2ac4ffe..7889e1ef7fad 100644
> --- a/net/ieee802154/socket.c
> +++ b/net/ieee802154/socket.c
> @@ -251,9 +251,6 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
>   		return -EOPNOTSUPP;
>   	}
>   
> -	if (!size)
> -		return -EINVAL;
> -
>   	lock_sock(sk);
>   	if (!sk->sk_bound_dev_if)
>   		dev = dev_getfirstbyhwtype(sock_net(sk), ARPHRD_IEEE802154);

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt