lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yz8rWoYlF8sjbkBz@shell.armlinux.org.uk> Date: Thu, 6 Oct 2022 20:24:10 +0100 From: "Russell King (Oracle)" <linux@...linux.org.uk> To: Shenwei Wang <shenwei.wang@....com> Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, imx@...ts.linux.dev Subject: Re: [PATCH 1/1] net: phylink: add phylink_set_mac_pm() helper On Thu, Oct 06, 2022 at 12:02:37PM -0500, Shenwei Wang wrote: > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > index e9d62f9598f9..a741c4bb5dd5 100644 > --- a/drivers/net/phy/phylink.c > +++ b/drivers/net/phy/phylink.c > @@ -1722,6 +1722,15 @@ void phylink_stop(struct phylink *pl) > } > EXPORT_SYMBOL_GPL(phylink_stop); > > +void phylink_set_mac_pm(struct phylink *pl) This needs documenting. The documentation for the function needs to mention when this should be called - so users are guided towards calling it at the right place in their drivers, rather than leaving them trying to figure it out and possibly get it wrong. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists