lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yz7iDEjVbHrPUPT4@salvia> Date: Thu, 6 Oct 2022 16:11:24 +0200 From: Pablo Neira Ayuso <pablo@...filter.org> To: Xin Long <lucien.xin@...il.com> Cc: network dev <netdev@...r.kernel.org>, dev@...nvswitch.org, ovs-dev@...nvswitch.org, davem@...emloft.net, kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Pravin B Shelar <pshelar@....org>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Florian Westphal <fw@...len.de>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Davide Caratti <dcaratti@...hat.com>, Oz Shlomo <ozsh@...dia.com>, Paul Blakey <paulb@...dia.com>, Ilya Maximets <i.maximets@....org>, Eelco Chaudron <echaudro@...hat.com> Subject: Re: [PATCH net-next 3/3] net: sched: add helper support in act_ct On Tue, Oct 04, 2022 at 09:19:56PM -0400, Xin Long wrote: [...] > @@ -1119,6 +1135,22 @@ static int tcf_ct_act(struct sk_buff *skb, const struct tc_action *a, > if (err != NF_ACCEPT) > goto drop; > > + if (commit && p->helper && !nfct_help(ct)) { > + err = __nf_ct_try_assign_helper(ct, p->tmpl, GFP_ATOMIC); > + if (err) > + goto drop; > + add_helper = true; > + if (p->ct_action & TCA_CT_ACT_NAT && !nfct_seqadj(ct)) { > + if (!nfct_seqadj_ext_add(ct)) You can only add ct extensions if ct is !nf_ct_is_confirmed(ct)), is this guaranteed in this codepath? > + return -EINVAL; > + } > + } > + > + if (nf_ct_is_confirmed(ct) ? ((!cached && !skip_add) || add_helper) : commit) { > + if (nf_ct_helper(skb, family) != NF_ACCEPT) > + goto drop; > + } > + > if (commit) { > tcf_ct_act_set_mark(ct, p->mark, p->mark_mask); > tcf_ct_act_set_labels(ct, p->labels, p->labels_mask);
Powered by blists - more mailing lists