netdev - Re: [PATCH v2 net] ipv4: Handle attempt to delete multipath route when fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2022 09:11:25 -0600
From:   David Ahern <dsahern@...nel.org>
To:     kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com
Cc:     netdev@...r.kernel.org, idosch@...sch.org,
        Gwangun Jung <exsociety@...il.com>
Subject: Re: [PATCH v2 net] ipv4: Handle attempt to delete multipath route
 when fib_info contains an nh reference

On 10/6/22 9:08 AM, David Ahern wrote:
> diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh
> index d5a0dd548989..15556138de76 100755
> --- a/tools/testing/selftests/net/fib_nexthops.sh
> +++ b/tools/testing/selftests/net/fib_nexthops.sh
> @@ -1223,6 +1223,11 @@ ipv4_fcnal()
>  	log_test $rc 0 "Delete nexthop route warning"
>  	run_cmd "$IP route delete 172.16.101.1/32 nhid 12"
>  	run_cmd "$IP nexthop del id 12"
> +
> +	run_cmd "$IP nexthop add id 21 via 172.16.1.6 dev veth1"
> +	run_cmd "$IP ro add 172.16.101.0/24 nhid 21"
> +	run_cmd "$IP ro del 172.16.101.0/24 nexthop via 172.16.1.7 dev veth1 nexthop via 172.16.1.8 dev veth1"
> +	log_test $? 1 "Delete multipath route with only nh id based entry"
>  }
>  
>  ipv4_grp_fcnal()

Did not intend to add this chunk to v2; it was hanging around the
branch. :-)

The return code check is wrong - should be 2, not 1. I will send a v3
later today.