netdev - Re: [PATCH net OR wpan] net: ieee802154: return -EINVAL for unknown addr type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Oct 2022 09:44:18 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Alexander Aring <aahringo@...hat.com>, tcs.kernel@...il.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux-wpan@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net OR wpan] net: ieee802154: return -EINVAL for unknown
 addr type

Hello.

On 06.10.22 04:02, Alexander Aring wrote:
> This patch adds handling to return -EINVAL for an unknown addr type. The
> current behaviour is to return 0 as successful but the size of an
> unknown addr type is not defined and should return an error like -EINVAL.
> 
> Fixes: 94160108a70c ("net/ieee802154: fix uninit value bug in dgram_sendmsg")
> Signed-off-by: Alexander Aring <aahringo@...hat.com>
> ---
>   include/net/ieee802154_netdev.h | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/include/net/ieee802154_netdev.h b/include/net/ieee802154_netdev.h
> index a8994f307fc3..03b64bf876a4 100644
> --- a/include/net/ieee802154_netdev.h
> +++ b/include/net/ieee802154_netdev.h
> @@ -185,21 +185,27 @@ static inline int
>   ieee802154_sockaddr_check_size(struct sockaddr_ieee802154 *daddr, int len)
>   {
>   	struct ieee802154_addr_sa *sa;
> +	int ret = 0;
>   
>   	sa = &daddr->addr;
>   	if (len < IEEE802154_MIN_NAMELEN)
>   		return -EINVAL;
>   	switch (sa->addr_type) {
> +	case IEEE802154_ADDR_NONE:
> +		break;
>   	case IEEE802154_ADDR_SHORT:
>   		if (len < IEEE802154_NAMELEN_SHORT)
> -			return -EINVAL;
> +			ret = -EINVAL;
>   		break;
>   	case IEEE802154_ADDR_LONG:
>   		if (len < IEEE802154_NAMELEN_LONG)
> -			return -EINVAL;
> +			ret = -EINVAL;
> +		break;
> +	default:
> +		ret = -EINVAL;
>   		break;
>   	}
> -	return 0;
> +	return ret;
>   }
>   
>   static inline void ieee802154_addr_from_sa(struct ieee802154_addr *a,

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt