lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y0CPmuxTRr799AR5@euler> Date: Fri, 7 Oct 2022 13:44:10 -0700 From: Colin Foster <colin.foster@...advantage.com> To: Vladimir Oltean <olteanv@...il.com> Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>, Linus Walleij <linus.walleij@...aro.org>, UNGLinuxDriver@...rochip.com, Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Manoil <claudiu.manoil@....com>, Lee Jones <lee@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Rob Herring <robh+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, Andrew Lunn <andrew@...n.ch> Subject: Re: [PATCH v3 net-next 12/14] dt-bindings: net: dsa: ocelot: add ocelot-ext documentation On Tue, Sep 27, 2022 at 11:26:00PM +0300, Vladimir Oltean wrote: > On Sun, Sep 25, 2022 at 05:29:26PM -0700, Colin Foster wrote: > > + > > + The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513, > > + and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS > > + processor that natively support Linux. Additionally, all four devices > > + support control over external interfaces, SPI and PCIe. The Ocelot-Ext > > + driver is for the external control portion. > > + > > + The following PHY interface types are supported: > > + > > + - phy-mode = "internal": on ports 0, 1, 2, 3 > > More PHY interface types are supported. Please document them all. > It doesn't matter what the driver supports. Drivers and device tree > blobs should be able to have different lifetimes. A driver which doesn't > support the SERDES ports should work with a device tree that defines > them, and a driver that supports the SERDES ports should work with a > device tree that doesn't. > > Similar for the other stuff which isn't documented (interrupts, SERDES > PHY handles etc). Since there is already an example with vsc7514, you > know how they need to look, even if they don't work yet on your > hardware, no? > With regards to the interrupts - I don't really have a concept of how those will work, since there isn't a processor for those lines to interrupt. So while there is this for the 7514: interrupts = <18 21 16>; interrupt-names = "ptp_rdy", "xtr", "fdma"; it seems like there isn't anything to add there. That is, unless there's something deeper that is going on that I don't fully understand yet. It wouldn't be the first time and, realistically, won't be the last. I'll copy the 7514 for now, as I plan to send out an RFC shortly with all these updates.
Powered by blists - more mailing lists