lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yz96//Gf4tCteJLm@codewreck.org> Date: Fri, 7 Oct 2022 10:03:59 +0900 From: Dominique Martinet <asmadeus@...ewreck.org> To: Christian Schoenebeck <linux_oss@...debyte.com> Cc: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Eric Van Hensbergen <ericvh@...il.com>, Latchesar Ionkov <lucho@...kov.net>, syzbot <syzbot+8b41a1365f1106fd0f33@...kaller.appspotmail.com>, v9fs-developer@...ts.sourceforge.net, syzkaller-bugs@...glegroups.com, netdev@...r.kernel.org Subject: Re: [PATCH] 9p/trans_fd: always use O_NONBLOCK read/write Christian Schoenebeck wrote on Thu, Oct 06, 2022 at 04:55:23PM +0200: > > diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c > > index e758978b44be..9870597da583 100644 > > --- a/net/9p/trans_fd.c > > +++ b/net/9p/trans_fd.c > > @@ -821,11 +821,13 @@ static int p9_fd_open(struct p9_client *client, int > > rfd, int wfd) goto out_free_ts; > > if (!(ts->rd->f_mode & FMODE_READ)) > > goto out_put_rd; > > + ts->rd->f_flags |= O_NONBLOCK; > > ... I think this deserves a short comment like: > > /* prevent hung task with pipes */ Good point, I've sneaked in this comment: /* prevent workers from hanging on IO when fd is a pipe */ https://github.com/martinetd/linux/commit/ef575281b21e9a34dfae544a187c6aac2ae424a9 > Reviewed-by: Christian Schoenebeck <linux_oss@...debyte.com> Thank you! -- Dominique
Powered by blists - more mailing lists