lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Oct 2022 10:54:31 +0200 From: Guillaume Nault <gnault@...hat.com> To: Jakub Kicinski <kuba@...nel.org> Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com, robh@...nel.org, johannes@...solutions.net, ecree.xilinx@...il.com, stephen@...workplumber.org, sdf@...gle.com, f.fainelli@...il.com, fw@...len.de, linux-doc@...r.kernel.org, razor@...ckwall.org, nicolas.dichtel@...nd.com Subject: Re: [PATCH net-next v2 3/7] net: add basic C code generators for Netlink On Thu, Oct 06, 2022 at 07:55:37AM -0700, Jakub Kicinski wrote: > On Thu, 6 Oct 2022 14:51:09 +0200 Guillaume Nault wrote: > > > v2: - use /* */ comments instead of // > > > > Probably not a very interesting feedback, but there > > are still many comments generated in the // style. > > It's slightly unclear to me what our policy on comments is now. > I can fix all up - the motivation for the change in v2 was that > in uAPI apparently its completely forbidden to use anything that's > not ANSI C :S I didn't realise the v2 comment was for uapi headers only. So I was surprised to see // comments in the generated files. > Gotta keep that compatibility with the all important Borland compiler > or something? Personnaly, I like the /* */ style, but I don't think my personnal taste should influence this patch set. I genuinely thought you wanted to convert all comments, hence my feedback. Feel free to ignore it :).
Powered by blists - more mailing lists