netdev - Re: [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in dsa_port_phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221008130639.6nhumidbbw5duesd@skbuf>
Date:   Sat, 8 Oct 2022 13:06:40 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Yang Yingliang <yangyingliang@...wei.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jiri@...dia.com" <jiri@...dia.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net] net: dsa: fix wrong pointer passed to PTR_ERR() in
 dsa_port_phylink_create()

On Sat, Oct 08, 2022 at 04:39:42PM +0800, Yang Yingliang wrote:
> Fix wrong pointer passed to PTR_ERR() in dsa_port_phylink_create() to print
> error message.
> 
> Fixes: cf5ca4ddc37a ("net: dsa: don't leave dangling pointers in dp->pl when failing")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>

Thanks!

>  net/dsa/port.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/dsa/port.c b/net/dsa/port.c
> index e4a0513816bb..208168276995 100644
> --- a/net/dsa/port.c
> +++ b/net/dsa/port.c
> @@ -1681,7 +1681,7 @@ int dsa_port_phylink_create(struct dsa_port *dp)
>  	pl = phylink_create(&dp->pl_config, of_fwnode_handle(dp->dn),
>  			    mode, &dsa_port_phylink_mac_ops);
>  	if (IS_ERR(pl)) {
> -		pr_err("error creating PHYLINK: %ld\n", PTR_ERR(dp->pl));
> +		pr_err("error creating PHYLINK: %ld\n", PTR_ERR(pl));
>  		return PTR_ERR(pl);
>  	}
>  
> -- 
> 2.25.1
>