lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 8 Oct 2022 22:18:45 +0000 From: David Laight <David.Laight@...LAB.COM> To: "'Jason A. Donenfeld'" <Jason@...c4.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev" <patches@...ts.linux.dev> CC: Andreas Noever <andreas.noever@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Borislav Petkov <bp@...en8.de>, "Catalin Marinas" <catalin.marinas@....com>, Christoph Böhmwalder <christoph.boehmwalder@...bit.com>, Christoph Hellwig <hch@....de>, Christophe Leroy <christophe.leroy@...roup.eu>, Daniel Borkmann <daniel@...earbox.net>, Dave Airlie <airlied@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>, "David S . Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, Florian Westphal <fw@...len.de>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "H . Peter Anvin" <hpa@...or.com>, Heiko Carstens <hca@...ux.ibm.com>, Helge Deller <deller@....de>, Herbert Xu <herbert@...dor.apana.org.au>, Huacai Chen <chenhuacai@...nel.org>, Hugh Dickins <hughd@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "James E . J . Bottomley" <jejb@...ux.ibm.com>, Jan Kara <jack@...e.com>, Jason Gunthorpe <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>, Johannes Berg <johannes@...solutions.net>, Jonathan Corbet <corbet@....net>, Jozsef Kadlecsik <kadlec@...filter.org>, KP Singh <kpsingh@...nel.org>, Kees Cook <keescook@...omium.org>, Marco Elver <elver@...gle.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, "Michael Ellerman" <mpe@...erman.id.au>, Pablo Neira Ayuso <pablo@...filter.org>, "Paolo Abeni" <pabeni@...hat.com>, Peter Zijlstra <peterz@...radead.org>, "Richard Weinberger" <richard@....at>, Russell King <linux@...linux.org.uk>, "Theodore Ts'o" <tytso@....edu>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, "Thomas Gleixner" <tglx@...utronix.de>, Thomas Graf <tgraf@...g.ch>, Ulf Hansson <ulf.hansson@...aro.org>, Vignesh Raghavendra <vigneshr@...com>, WANG Xuerui <kernel@...0n.name>, Will Deacon <will@...nel.org>, Yury Norov <yury.norov@...il.com>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>, "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>, "linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>, "linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>, Toke Høiland-Jørgensen <toke@...e.dk>, Chuck Lever <chuck.lever@...cle.com>, Jan Kara <jack@...e.cz>, Mika Westerberg <mika.westerberg@...ux.intel.com> Subject: RE: [PATCH v4 4/6] treewide: use get_random_u32() when possible From: Jason A. Donenfeld > Sent: 07 October 2022 19:01 > > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real function. The same also applies to get_random_int(), which is > just a wrapper around get_random_u32(). > ... > diff --git a/net/802/garp.c b/net/802/garp.c > index f6012f8e59f0..c1bb67e25430 100644 > --- a/net/802/garp.c > +++ b/net/802/garp.c > @@ -407,7 +407,7 @@ static void garp_join_timer_arm(struct garp_applicant *app) > { > unsigned long delay; > > - delay = (u64)msecs_to_jiffies(garp_join_time) * prandom_u32() >> 32; > + delay = (u64)msecs_to_jiffies(garp_join_time) * get_random_u32() >> 32; > mod_timer(&app->join_timer, jiffies + delay); > } > > diff --git a/net/802/mrp.c b/net/802/mrp.c > index 35e04cc5390c..3e9fe9f5d9bf 100644 > --- a/net/802/mrp.c > +++ b/net/802/mrp.c > @@ -592,7 +592,7 @@ static void mrp_join_timer_arm(struct mrp_applicant *app) > { > unsigned long delay; > > - delay = (u64)msecs_to_jiffies(mrp_join_time) * prandom_u32() >> 32; > + delay = (u64)msecs_to_jiffies(mrp_join_time) * get_random_u32() >> 32; > mod_timer(&app->join_timer, jiffies + delay); > } > Aren't those: delay = prandom_u32_max(msecs_to_jiffies(xxx_join_time)); David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
Powered by blists - more mailing lists