netdev - Re: [PATCH] iplink_can: add missing `]' of the bitrate, dbitrate and termination arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 12:54:20 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc:     linux-can@...r.kernel.org, David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH] iplink_can: add missing `]' of the bitrate, dbitrate and
 termination arrays

Hello Vincent,

thanks for taking care, and finding the other missing closing ']'!

On 10.10.2022 19:50:41, Vincent Mailhol wrote:
> The command "ip --details link show canX" misses the closing bracket
> `]' of the bitrate, the dbitrate and the termination arrays. The JSON
> output is not impacted.
> 
> Change the first argument of close_json_array() from PRINT_JSON to
> PRINT_ANY to fix the problem. The second argument is already set
> correctly.
> 
> Fixes: 67f3c7a5cc0d ("iplink_can: use PRINT_ANY to factorize code and fix signedness")
> Reported-by: Marc Kleine-Budde <mkl@...gutronix.de> via vger.kernel.org>
                                                      ^^^^^^^^^^^^^^^^^^^^
Copy/Paste mistake? Please remove :)

> Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>

Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)