netdev - Re: [bpf-next v8 0/3] bpftool: Add autoattach for bpf prog load|loadall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2022 17:17:44 +0100
From:   Quentin Monnet <quentin@...valent.com>
To:     Wang Yufen <wangyufen@...wei.com>, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, davem@...emloft.net, kuba@...nel.org,
        hawk@...nel.org, nathan@...nel.org, ndesaulniers@...gle.com,
        trix@...hat.com
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [bpf-next v8 0/3] bpftool: Add autoattach for bpf prog
 load|loadall

2022-10-10 18:59 UTC+0800 ~ Wang Yufen <wangyufen@...wei.com>
> This patchset add "autoattach" optional for "bpftool prog load(_all)" to support
> one-step load-attach-pin_link.
> 
> v7 -> v8: for the programs not supporting autoattach, fall back to reguler pinning
> 	  instead of skipping
> v6 -> v7: add info msg print and update doc for the skip program
> v5 -> v6: skip the programs not supporting auto-attach,
> 	  and change optional name from "auto_attach" to "autoattach"
> v4 -> v5: some formatting nits of doc
> v3 -> v4: rename functions, update doc, bash and do_help()
> v2 -> v3: switch to extend prog load command instead of extend perf
> v2: https://patchwork.kernel.org/project/netdevbpf/patch/20220824033837.458197-1-weiyongjun1@huawei.com/
> v1: https://patchwork.kernel.org/project/netdevbpf/patch/20220816151725.153343-1-weiyongjun1@huawei.com/
> 
> Wang Yufen (3):
>   bpftool: Add autoattach for bpf prog load|loadall
>   bpftool: Update doc (add autoattach to prog load)
>   bpftool: Update the bash completion(add autoattach to prog load)
> 
>  tools/bpf/bpftool/Documentation/bpftool-prog.rst | 15 ++++-
>  tools/bpf/bpftool/bash-completion/bpftool        |  1 +
>  tools/bpf/bpftool/prog.c                         | 78 +++++++++++++++++++++++-
>  3 files changed, 90 insertions(+), 4 deletions(-)
> 

The series looks good to me, thank you!

Reviewed-by: Quentin Monnet <quentin@...valent.com>