netdev - Re: [PATCH linux-next] iavf: Replace __FUNCTION__ with __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e38c0f1-1b6c-1825-12c1-5ad135865c0c@intel.com>
Date:   Tue, 11 Oct 2022 14:46:07 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     <yexingchen116@...il.com>, <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <intel-wired-lan@...ts.osuosl.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        ye xingchen <ye.xingchen@....com.cn>
Subject: Re: [PATCH linux-next] iavf: Replace __FUNCTION__ with __func__

On 10/11/2022 4:16 AM, yexingchen116@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> __FUNCTION__ exists only for backwards compatibility reasons with old
> gcc versions. Replace it with __func__.
> 
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>   drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..98ab11972f5c 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
>   		iavf_close(netdev);
>   
>   	if (iavf_lock_timeout(&adapter->crit_lock, 5000))
> -		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __FUNCTION__);
> +		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __func__);
>   	/* Prevent the watchdog from running. */
>   	iavf_change_state(adapter, __IAVF_REMOVE);
>   	adapter->aq_required = 0;

yeah, how'd that sneak in there? Thanks!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>