lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Oct 2022 18:37:00 -0700 From: Andrii Nakryiko <andrii.nakryiko@...il.com> To: Xu Kuohai <xukuohai@...wei.com> Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, Kumar Kartikeya Dwivedi <memxor@...il.com>, Alan Maguire <alan.maguire@...cle.com>, Delyan Kratunov <delyank@...com>, Lorenzo Bianconi <lorenzo@...nel.org> Subject: Re: [PATCH bpf v3 0/6] Fix bugs found by ASAN when running selftests On Mon, Oct 10, 2022 at 7:08 AM Xu Kuohai <xukuohai@...wei.com> wrote: > Thanks for the fixes! I left a few comments in a few patches, please address those. But also please provide a commit message, even if a single line one. Kernel style dictates that the commit message shouldn't be empty. And I think none of these fixes are critical enough to go to bpf tree, please target bpf-next for next revision. Thanks. > v3: > - Fix error failure of case test_xdp_adjust_tail_grow exposed by this series > > v2: https://lore.kernel.org/bpf/20221010070454.577433-1-xukuohai@huaweicloud.com > - Rebase and fix conflict > > v1: https://lore.kernel.org/bpf/20221009131830.395569-1-xukuohai@huaweicloud.com > > Xu Kuohai (6): > libbpf: Fix use-after-free in btf_dump_name_dups > libbpf: Fix memory leak in parse_usdt_arg() > selftests/bpf: Fix memory leak caused by not destroying skeleton > selftest/bpf: Fix memory leak in kprobe_multi_test > selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow > selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c > > tools/lib/bpf/btf_dump.c | 47 +++++++++++---- > tools/lib/bpf/usdt.c | 59 +++++++++++-------- > .../bpf/prog_tests/kprobe_multi_test.c | 17 +++--- > .../selftests/bpf/prog_tests/map_kptr.c | 3 +- > .../selftests/bpf/prog_tests/tracing_struct.c | 3 +- > .../bpf/prog_tests/xdp_adjust_tail.c | 7 ++- > 6 files changed, 86 insertions(+), 50 deletions(-) > > -- > 2.30.2 >
Powered by blists - more mailing lists