lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 11 Oct 2022 04:40:00 +0000 (UTC)
From:   Kalle Valo <>
To:     Fedor Pchelkin <>
Cc:     Toke Høiland-Jørgensen <>,
        Fedor Pchelkin <>,
        "David S. Miller" <>,
        Eric Dumazet <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,,,,
        Alexey Khoroshilov <>,
Subject: Re: [PATCH v2] ath9k: hif_usb: Fix use-after-free in

Fedor Pchelkin <> wrote:

> It is possible that skb is freed in ath9k_htc_rx_msg(), then
> usb_submit_urb() fails and we try to free skb again. It causes
> use-after-free bug. Moreover, if alloc_skb() fails, urb->context becomes
> NULL but rx_buf is not freed and there can be a memory leak.
> The patch removes unnecessary nskb and makes skb processing more clear: it
> is supposed that ath9k_htc_rx_msg() either frees old skb or passes its
> managing to another callback function.
> Found by Linux Verification Center ( with Syzkaller.
> Fixes: 3deff76095c4 ("ath9k_htc: Increase URB count for REG_IN pipe")
> Signed-off-by: Fedor Pchelkin <>
> Signed-off-by: Alexey Khoroshilov <>
> Acked-by: Toke Høiland-Jørgensen <>
> Signed-off-by: Kalle Valo <>

Patch applied to ath-next branch of ath.git, thanks.

dd95f2239fc8 wifi: ath9k: hif_usb: Fix use-after-free in ath9k_hif_usb_reg_in_cb()


Powered by blists - more mailing lists