netdev - Re: [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0UwqMZQ6n+G//aD@shredder>
Date:   Tue, 11 Oct 2022 12:00:24 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Eyal Birger <eyal.birger@...il.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, steffen.klassert@...unet.com,
        herbert@...dor.apana.org.au, dsahern@...nel.org,
        contact@...elbtn.com, pablo@...filter.org,
        nicolas.dichtel@...nd.com, razor@...ckwall.org,
        daniel@...earbox.net, netdev@...r.kernel.org
Subject: Re: [PATCH ipsec] xfrm: lwtunnel: squelch kernel warning in case
 XFRM encap type is not available

On Tue, Oct 11, 2022 at 11:01:37AM +0300, Eyal Birger wrote:
> Ido reported that a kernel warning [1] can be triggered from
> user space when the kernel is compiled with CONFIG_MODULES=y and
> CONFIG_XFRM=n when adding an xfrm encap type route, e.g:
> 
> $ ip route add 198.51.100.0/24 dev dummy1 encap xfrm if_id 1
> Error: lwt encapsulation type not supported.
> 
> The reason for the warning is that the LWT infrastructure has an
> autoloading feature which is meant only for encap types that don't
> use a net device,  which is not the case in xfrm encap.
> 
> Mute this warning for xfrm encap as there's no encap module to autoload
> in this case.

[...]

> 
> Reported-by: Ido Schimmel <idosch@...sch.org>
> Fixes: 2c2493b9da91 ("xfrm: lwtunnel: add lwtunnel support for xfrm interfaces in collect_md mode")
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>

Tested-by: Ido Schimmel <idosch@...dia.com>

Thanks