netdev - Re: [PATCH net] net: ethernet: ti: am65-cpsw: set correct devlink flavour for unused ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2022 14:44:43 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Siddharth Vadapalli <s-vadapalli@...com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw: set correct devlink
 flavour for unused ports

On Tue, Oct 11, 2022 at 09:50:02AM +0200, Matthias Schiffer wrote:
> am65_cpsw_nuss_register_ndevs() skips calling devlink_port_type_eth_set()
> for ports without assigned netdev, triggering the following warning when
> DEVLINK_PORT_TYPE_WARN_TIMEOUT elapses after 3600s:
> 
>     Type was not set for devlink port.
>     WARNING: CPU: 0 PID: 129 at net/core/devlink.c:8095 devlink_port_type_warn+0x18/0x30
> 
> Fixes: 0680e20af5fb ("net: ethernet: ti: am65-cpsw: Fix devlink port register sequence")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew