lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <TY2PR06MB3424C10AC28421199B02905D85229@TY2PR06MB3424.apcprd06.prod.outlook.com> Date: Wed, 12 Oct 2022 06:45:27 +0000 From: Angus Chen <angus.chen@...uarmicro.com> To: Michael Ellerman <mpe@...erman.id.au>, "Michael S. Tsirkin" <mst@...hat.com> CC: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "alvaro.karsz@...id-run.com" <alvaro.karsz@...id-run.com>, "gavinl@...dia.com" <gavinl@...dia.com>, "jasowang@...hat.com" <jasowang@...hat.com>, "lingshan.zhu@...el.com" <lingshan.zhu@...el.com>, "mst@...hat.com" <mst@...hat.com>, "wangdeming@...pur.com" <wangdeming@...pur.com>, "xiujianfeng@...wei.com" <xiujianfeng@...wei.com>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: RE: [GIT PULL] virtio: fixes, features > -----Original Message----- > From: Michael Ellerman <mpe@...erman.id.au> > Sent: Wednesday, October 12, 2022 2:21 PM > To: Michael S. Tsirkin <mst@...hat.com> > Cc: kvm@...r.kernel.org; virtualization@...ts.linux-foundation.org; > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; > alvaro.karsz@...id-run.com; Angus Chen <angus.chen@...uarmicro.com>; > gavinl@...dia.com; jasowang@...hat.com; lingshan.zhu@...el.com; > mst@...hat.com; wangdeming@...pur.com; xiujianfeng@...wei.com; > linuxppc-dev@...ts.ozlabs.org; Linus Torvalds <torvalds@...ux-foundation.org> > Subject: Re: [GIT PULL] virtio: fixes, features > > "Michael S. Tsirkin" <mst@...hat.com> writes: > > The following changes since commit > 4fe89d07dcc2804c8b562f6c7896a45643d34b2f: > > > > Linux 6.0 (2022-10-02 14:09:07 -0700) > > > > are available in the Git repository at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > tags/for_linus > > > > for you to fetch changes up to > 71491c54eafa318fdd24a1f26a1c82b28e1ac21d: > > > > virtio_pci: don't try to use intxif pin is zero (2022-10-07 20:00:44 -0400) > > > > ---------------------------------------------------------------- > > virtio: fixes, features > > > > 9k mtu perf improvements > > vdpa feature provisioning > > virtio blk SECURE ERASE support > > > > Fixes, cleanups all over the place. > > > > Signed-off-by: Michael S. Tsirkin <mst@...hat.com> > > > > ---------------------------------------------------------------- > > Alvaro Karsz (1): > > virtio_blk: add SECURE ERASE command support > > > > Angus Chen (1): > > virtio_pci: don't try to use intxif pin is zero > > This commit breaks virtio_pci for me on powerpc, when running as a qemu > guest. > > vp_find_vqs() bails out because pci_dev->pin == 0. > > But pci_dev->irq is populated correctly, so vp_find_vqs_intx() would > succeed if we called it - which is what the code used to do. > > I think this happens because pci_dev->pin is not populated in > pci_assign_irq(). Yes,you are right. > > I would absolutely believe this is bug in our PCI code, but I think it > may also affect other platforms that use of_irq_parse_and_map_pci(). > Should I just revert or submit a new version? > cheers
Powered by blists - more mailing lists