netdev - Re: [PATCH net v1] net/mlx5: Make ASO poll CQ usable in atomic context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166556281621.4495.12120662116539689622.git-patchwork-notify@kernel.org>
Date:   Wed, 12 Oct 2022 08:20:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Leon Romanovsky <leon@...nel.org>
Cc:     davem@...emloft.net, kuba@...nel.org, leonro@...dia.com,
        edumazet@...gle.com, netdev@...r.kernel.org, pabeni@...hat.com,
        saeedm@...dia.com
Subject: Re: [PATCH net v1] net/mlx5: Make ASO poll CQ usable in atomic context

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Tue, 11 Oct 2022 16:14:55 +0300 you wrote:
> From: Leon Romanovsky <leonro@...dia.com>
> 
> Poll CQ functions shouldn't sleep as they are called in atomic context.
> The following splat appears once the mlx5_aso_poll_cq() is used in such
> flow.
> 
>  BUG: scheduling while atomic: swapper/17/0/0x00000100
>  Modules linked in: sch_ingress openvswitch nsh mlx5_vdpa vringh vhost_iotlb vdpa mlx5_ib mlx5_core xt_conntrack xt_MASQUERADE nf_conntrack_netlink nfnetlink xt_addrtype iptable_nat nf_nat br_netfilter overlay rpcrdma rdma_ucm ib_iser libiscsi scsi_transport_iscsi ib_umad rdma_cm ib_ipoib iw_cm ib_cm ib_uverbs ib_core fuse [last unloaded: mlx5_core]
>  CPU: 17 PID: 0 Comm: swapper/17 Tainted: G        W          6.0.0-rc2+ #13
>  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014
>  Call Trace:
>   <IRQ>
>   dump_stack_lvl+0x34/0x44
>   __schedule_bug.cold+0x47/0x53
>   __schedule+0x4b6/0x670
>   ? hrtimer_start_range_ns+0x28d/0x360
>   schedule+0x50/0x90
>   schedule_hrtimeout_range_clock+0x98/0x120
>   ? __hrtimer_init+0xb0/0xb0
>   usleep_range_state+0x60/0x90
>   mlx5_aso_poll_cq+0xad/0x190 [mlx5_core]
>   mlx5e_ipsec_aso_update_curlft+0x81/0xb0 [mlx5_core]
>   xfrm_timer_handler+0x6b/0x360
>   ? xfrm_find_acq_byseq+0x50/0x50
>   __hrtimer_run_queues+0x139/0x290
>   hrtimer_run_softirq+0x7d/0xe0
>   __do_softirq+0xc7/0x272
>   irq_exit_rcu+0x87/0xb0
>   sysvec_apic_timer_interrupt+0x72/0x90
>   </IRQ>
>   <TASK>
>   asm_sysvec_apic_timer_interrupt+0x16/0x20
>  RIP: 0010:default_idle+0x18/0x20
>  Code: ae 7d ff ff cc cc cc cc cc cc cc cc cc cc cc cc cc cc 0f 1f 44 00 00 8b 05 b5 30 0d 01 85 c0 7e 07 0f 00 2d 0a e3 53 00 fb f4 <c3> 0f 1f 80 00 00 00 00 0f 1f 44 00 00 65 48 8b 04 25 80 ad 01 00
>  RSP: 0018:ffff888100883ee0 EFLAGS: 00000242
>  RAX: 0000000000000001 RBX: ffff888100849580 RCX: 4000000000000000
>  RDX: 0000000000000001 RSI: 0000000000000083 RDI: 000000000008863c
>  RBP: 0000000000000011 R08: 00000064e6977fa9 R09: 0000000000000001
>  R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
>  R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
>   default_idle_call+0x37/0xb0
>   do_idle+0x1cd/0x1e0
>   cpu_startup_entry+0x19/0x20
>   start_secondary+0xfe/0x120
>   secondary_startup_64_no_verify+0xcd/0xdb
>   </TASK>
>  softirq: huh, entered softirq 8 HRTIMER 00000000a97c08cb with preempt_count 00000100, exited with 00000000?
> 
> [...]

Here is the summary with links:
  - [net,v1] net/mlx5: Make ASO poll CQ usable in atomic context
    https://git.kernel.org/netdev/net/c/739cfa34518e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html