lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8be89e06-5b26-6391-0427-b4e5b6ab66ab@datenfreihafen.org> Date: Wed, 12 Oct 2022 12:48:06 +0200 From: Stefan Schmidt <stefan@...enfreihafen.org> To: Miquel Raynal <miquel.raynal@...tlin.com>, Alexander Aring <alex.aring@...il.com>, linux-wpan@...r.kernel.org Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org, David Girault <david.girault@...vo.com>, Romuald Despres <romuald.despres@...vo.com>, Frederic Blain <frederic.blain@...vo.com>, Nicolas Schodet <nico@...fr.eu.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com> Subject: Re: [PATCH wpan/next v4 5/8] ieee802154: hwsim: Implement address filtering Hello Miquel. This patch has given me some checkpatch wawrnings and errors. Commit d9abecc4a0fc ("ieee802154: hwsim: Implement address filtering") ---------------------------------------------------------------------- CHECK: Blank lines aren't necessary after an open brace '{' #53: FILE: drivers/net/ieee802154/mac802154_hwsim.c:162: + if (hw->phy->filtering == IEEE802154_FILTERING_4_FRAME_FIELDS) { + ERROR: code indent should use tabs where possible #128: FILE: drivers/net/ieee802154/mac802154_hwsim.c:237: + }$ WARNING: please, no spaces at the start of a line #128: FILE: drivers/net/ieee802154/mac802154_hwsim.c:237: + }$ total: 1 errors, 1 warnings, 1 checks, 143 lines checked I fixed this up in palce for you tp proceed with applying this patches. Just so you are aware. regards Stefan Schmidt
Powered by blists - more mailing lists