[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y0azJlxthYXr7gMX@lunn.ch>
Date: Wed, 12 Oct 2022 14:29:26 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Pawel Dembicki <paweldembicki@...il.com>,
Lech Perczak <lech.perczak@...il.com>
Subject: Re: [net PATCH 1/2] net: dsa: qca8k: fix inband mgmt for big-endian
systems
On Mon, Oct 10, 2022 at 02:44:46PM +0200, Christian Marangi wrote:
> On Mon, Oct 10, 2022 at 08:53:01PM +0200, Andrew Lunn wrote:
> > > /* Special struct emulating a Ethernet header */
> > > struct qca_mgmt_ethhdr {
> > > - u32 command; /* command bit 31:0 */
> > > - u32 seq; /* seq 63:32 */
> > > - u32 mdio_data; /* first 4byte mdio */
> > > + __le32 command; /* command bit 31:0 */
> > > + __le32 seq; /* seq 63:32 */
> > > + __le32 mdio_data; /* first 4byte mdio */
> > > __be16 hdr; /* qca hdr */
> > > } __packed;
> >
> > It looks odd that hdr is BE while the rest are LE. Did you check this?
> >
> > Andrew
>
> Yes we did many test to analyze this and I just checked with some
> tcpdump that the hdr is BE everytime.
That might actual make sense. The comment says:
> > > /* Special struct emulating a Ethernet header */
And hdr is where the Ether type would be, which is network endian,
i.e. big endian.
Andrew
Powered by blists - more mailing lists