netdev - Re: [PATCH net] mctp: prevent double key removal and unref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Oct 2022 12:40:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jeremy Kerr <jk@...econstruct.com.au>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, matt@...econstruct.com.au,
        butterflyhuangxx@...il.com
Subject: Re: [PATCH net] mctp: prevent double key removal and unref

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Wed, 12 Oct 2022 10:08:51 +0800 you wrote:
> Currently, we have a bug where a simultaneous DROPTAG ioctl and socket
> close may race, as we attempt to remove a key from lists twice, and
> perform an unref for each removal operation. This may result in a uaf
> when we attempt the second unref.
> 
> This change fixes the race by making __mctp_key_remove tolerant to being
> called on a key that has already been removed from the socket/net lists,
> and only performs the unref when we do the actual remove. We also need
> to hold the list lock on the ioctl cleanup path.
> 
> [...]

Here is the summary with links:
  - [net] mctp: prevent double key removal and unref
    https://git.kernel.org/netdev/net/c/3a732b46736c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html