netdev - Re: [PATCH net-next 6/7] net: keep sk->sk_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66db31de-192a-cd8b-cc97-f2902f6fa687@amd.com>
Date:   Fri, 14 Oct 2022 14:02:54 +0530
From:   K Prateek Nayak <kprateek.nayak@....com>
To:     Shakeel Butt <shakeelb@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Wei Wang <weiwan@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Gautham Shenoy <gautham.shenoy@....com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Chen Yu <yu.c.chen@...el.com>,
        Abel Wu <wuyun.abel@...edance.com>,
        Yicong Yang <yangyicong@...ilicon.com>
Subject: Re: [PATCH net-next 6/7] net: keep sk->sk_forward_alloc as small as
 possible

Hello Shakeel,

Thank you for taking a look at this report.

On 10/13/2022 9:22 PM, Shakeel Butt wrote:
> On Thu, Oct 13, 2022 at 7:35 AM Eric Dumazet <edumazet@...gle.com> wrote:
>>
> [...]
>> The only regression that has been noticed was when memcg was in the picture.
>> Shakeel Butt sent patches to address this specific mm issue.
>> Not sure what happened to the series (
>> https://patchwork.kernel.org/project/linux-mm/list/?series=669584 )
>>
> 
> That series has been merged into Linus tree for 6.1-rc1.
> 
> Prateek, are you running the benchmarks in memory cgroups? Can you
> also test the latest Linus tree (or 6.1-rc1 when available) and see if
> the regression is still there?

I'm not running the benchmark in a cgroup / container but I'll rerun the
tests on v6.1-rc1 and let you know if the results improve.

> 
> thanks,
> Shakeel

--
Thanks and Regards,
Prateek