netdev - Re: [ovs-dev] [PATCH] tests: fix reference output for meter offload stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9e25530-e618-421c-922e-b9f2380bc19f@ovn.org>
Date:   Fri, 14 Oct 2022 15:00:32 +0200
From:   Ilya Maximets <i.maximets@....org>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        Marcelo Leitner <mleitner@...hat.com>
Cc:     i.maximets@....org, Davide Caratti <dcaratti@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>,
        Tianyu Yuan <tianyu.yuan@...igine.com>,
        Simon Horman <simon.horman@...igine.com>, dev@...nvswitch.org,
        oss-drivers <oss-drivers@...igine.com>, netdev@...r.kernel.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Oz Shlomo <ozsh@...dia.com>, Paul Blakey <paulb@...dia.com>,
        Vlad Buslov <vladbu@...dia.com>
Subject: Re: [ovs-dev] [PATCH] tests: fix reference output for meter offload
 stats

On 10/8/22 14:32, Jamal Hadi Salim wrote:
> On Fri, Oct 7, 2022 at 1:37 PM Marcelo Leitner <mleitner@...hat.com> wrote:
>>
>> On Fri, Oct 07, 2022 at 11:59:42AM -0400, Jamal Hadi Salim wrote:
>>> On Fri, Oct 7, 2022 at 11:01 AM Marcelo Leitner <mleitner@...hat.com> wrote:
>>>>
> 
> [..]
>>>
>>> It's mostly how people who offload (not sure about OVS) do it;
>>> example some of the switches out there.
>>
>> You mean with OK, DROP, TRAP or GOTO actions, right?
>>
>> Because for PIPE, it has:
>>                 } else if (is_tcf_gact_pipe(act)) {
>>                         NL_SET_ERR_MSG_MOD(extack, "Offload of
>> \"pipe\" action is not supported");
>>                         return -EOPNOTSUPP;
>>
> 
> I thought it was pipe but maybe it is OK(in my opinion that is a bad code
> for just "count"). We have some (at least NIC) hardware folks on the list.

IIRC, 'OK' action will stop the processing for the packet, so it can
only be used as a last action in the list.  But we need to count packets
as a very first action in the list.  So, that doesn't help.

> Note: we could create an alias to PIPE and call it COUNT if it helps.

Will that help with offloading of that action?  Why the PIPE is not
offloadable in the first place and will COUNT be offloadable?

> And yes, in retrospect we should probably have separated out accounting
> from the actions in tc. It makes a lot of sense in s/w - and would work fine for
> modern hardware but when you dont have as many counters as actions
> it's a challenge. Same thing with policers/meters.
> 
> cheers,
> jamal