netdev - RE: [EXT] Re: [PATCH v5 1/2] net: phylink: add mac_managed_pm in phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <PAXPR04MB918555BBE1A4B12736785BCD89249@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date:   Fri, 14 Oct 2022 14:35:36 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "\"linux-stm32@...md-mailman.stormreply.com\"" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "\" linux-arm-kernel@...ts.infradead.org\"" 
        <linux-arm-kernel@...ts.infradead.org>,
        "\" imx@...ts.linux.dev \"" <imx@...ts.linux.dev>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: RE: [EXT] Re: [PATCH v5 1/2] net: phylink: add mac_managed_pm in
 phylink_config structure


RESEND because some recipients' mail address were somehow corrupted.

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, October 13, 2022 6:12 PM
> To: Shenwei Wang <shenwei.wang@....com> On Thu, 13 Oct 2022 19:28:45 
> +0000 Shenwei Wang wrote:
> > > Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> > > mdio_bus_phy_resume() state"
> > >
> >
> > That was my original format. But it met the following warning when 
> > ran
> checkpatch.pl script:
> >
> > ./scripts/checkpatch.pl
> > 0001-net-phylink-add-mac_managed_pm-in-phylink_config-str.patch
> > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> 
> > ("<title
> line>")' - ie: 'Fixes: e6a39ffcfe22 ("net: stmmac: Enable 
> line>mac_managed_pm
> phylink config")'
> > #20:
> > Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect
> >
> > That's why I changed to the current tag format.
> 
> It needs to be all on one line:
> 
> Fixes: 47ac7b2f6a1f ("net: phy: Warn about incorrect 
> mdio_bus_phy_resume()
> state")
> 

En, that's the tricky.  Seems the rule of size limit is not applied for this use case.

> But I don't see 47ac7b2f6a1f in my trees, are you sure that's the 
> upstream commit id?

Just had a check again, and commit id on the upstream changed to 

commit 744d23c71af39c7dc77ac7c3cac87ae86a181a85 upstream

Will post a new patches to fix the tag.

Thanks,
Shenwei