netdev - Re: [PATCH net v2] sunhme: Uninitialized variable in happy_meal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Oct 2022 20:19:01 -0400
From:   Sean Anderson <seanga2@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net v2] sunhme: Uninitialized variable in
 happy_meal_init()

On 10/14/22 10:33, Dan Carpenter wrote:
> The "burst" string is only initialized for CONFIG_SPARC.  It should be
> set to "64" because that's what is used by PCI.
> 
> Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2: Use "64" instead of ""
> 
>   drivers/net/ethernet/sun/sunhme.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 62deed210a95..55f7ec836744 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp)
>   	void __iomem *erxregs      = hp->erxregs;
>   	void __iomem *bregs        = hp->bigmacregs;
>   	void __iomem *tregs        = hp->tcvregs;
> -	const char *bursts;
> +	const char *bursts = "64";
>   	u32 regtmp, rxcfg;
>   
>   	/* If auto-negotiation timer is running, kill it. */

Reviewed-by: Sean Anderson <seanga2@...il.com>