[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 15 Oct 2022 10:59:44 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Stefan Schmidt <stefan@...enfreihafen.org>
Cc: Alexander Aring <alex.aring@...il.com>, linux-wpan@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
David Girault <david.girault@...vo.com>,
Romuald Despres <romuald.despres@...vo.com>,
Frederic Blain <frederic.blain@...vo.com>,
Nicolas Schodet <nico@...fr.eu.org>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH wpan/next v4 5/8] ieee802154: hwsim: Implement address
filtering
Hi Stefan,
stefan@...enfreihafen.org wrote on Wed, 12 Oct 2022 12:48:06 +0200:
> Hello Miquel.
>
> This patch has given me some checkpatch wawrnings and errors.
>
> Commit d9abecc4a0fc ("ieee802154: hwsim: Implement address filtering")
> ----------------------------------------------------------------------
> CHECK: Blank lines aren't necessary after an open brace '{'
> #53: FILE: drivers/net/ieee802154/mac802154_hwsim.c:162:
> + if (hw->phy->filtering == IEEE802154_FILTERING_4_FRAME_FIELDS) {
> +
>
> ERROR: code indent should use tabs where possible
> #128: FILE: drivers/net/ieee802154/mac802154_hwsim.c:237:
> + }$
>
> WARNING: please, no spaces at the start of a line
> #128: FILE: drivers/net/ieee802154/mac802154_hwsim.c:237:
> + }$
>
> total: 1 errors, 1 warnings, 1 checks, 143 lines checked
>
> I fixed this up in palce for you tp proceed with applying this patches. Just so you are aware.
I'm sorry for these, I focused on getting the feature more than on the
presentation and I forgot to re-run checkpatch after all the copy-paste
handling towards hwsim. Next time I'll fix it myself, don't hesitate to
tell me when this happens ;-)
Thanks,
Miquèl
Powered by blists - more mailing lists