lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221017114056.1adb8d3e@kernel.org> Date: Mon, 17 Oct 2022 11:40:56 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Edward Cree <ecree.xilinx@...il.com> Cc: edward.cree@....com, netdev@...r.kernel.org, linux-net-drivers@....com, davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, habetsm.xilinx@...il.com, johannes@...solutions.net, marcelo.leitner@...il.com Subject: Re: [RFC PATCH v2 net-next 1/3] netlink: add support for formatted extack messages On Mon, 17 Oct 2022 13:04:35 +0100 Edward Cree wrote: > On 13/10/2022 16:29, Jakub Kicinski wrote: > > (I think splicing the "trunced extack:" with fmt will result > > in the format string getting stored in .ro twice?) > > Yes, it will. I guess we could splice "%s" with fmt in _both_ > calls (snprintf and net_warn_ratelimited), pass "" to one and > "truncated extack: " to the other. Then there's only a single > string to put in .ro. Is that worth the complication? I vote 'yes', with a simple comment next to it, it should be a fairly obvious trick to a reader of this code.
Powered by blists - more mailing lists