netdev - Re: [PATCH net-next 2/5] ptp: ocp: add Orolia timecard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2022 15:11:39 -0700
From:   Jonathan Lemon <jonathan.lemon@...il.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>,
        Richard Cochran <richardcochran@...il.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Vadim Fedorenko <vadfed@...com>,
        Charles Parent <charles.parent@...lia2s.com>
Subject: Re: [PATCH net-next 2/5] ptp: ocp: add Orolia timecard support

On 10/17/22 2:59 PM, Vadim Fedorenko wrote:
> From: Vadim Fedorenko <vadfed@...com>
> 
> This brings in the Orolia timecard support from the GitHub repository.
> The card uses different drivers to provide access to i2c EEPROM and
> firmware SPI flash. And it also has a bit different EEPROM map, but
> other parts of the code are the same and could be reused.
> 
> Co-developed-by: Charles Parent <charles.parent@...lia2s.com>
> Signed-off-by: Vadim Fedorenko <vadfed@...com>
> ---
>   drivers/ptp/ptp_ocp.c | 296 ++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 296 insertions(+)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index e5b28f89c8dd..cd4f3860d72a 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -13,9 +13,11 @@
>   #include <linux/clk-provider.h>
>   #include <linux/platform_device.h>
>   #include <linux/platform_data/i2c-xiic.h>
> +#include <linux/platform_data/i2c-ocores.h>
>   #include <linux/ptp_clock_kernel.h>
>   #include <linux/spi/spi.h>
>   #include <linux/spi/xilinx_spi.h>
> +#include <linux/spi/altera.h>
>   #include <net/devlink.h>
>   #include <linux/i2c.h>
>   #include <linux/mtd/mtd.h>
> @@ -28,6 +30,14 @@
>   #define PCI_VENDOR_ID_CELESTICA			0x18d4
>   #define PCI_DEVICE_ID_CELESTICA_TIMECARD	0x1008
>   
> +#ifndef PCI_VENDOR_ID_OROLIA
> +#define PCI_VENDOR_ID_OROLIA 0x1ad7
> +#endif
> +
> +#ifndef PCI_DEVICE_ID_OROLIA_ARTCARD
> +#define PCI_DEVICE_ID_OROLIA_ARTCARD 0xa000
> +#endif
Remove the #ifndef #endif pairs here.

Also, you're missing my SOB on these patches.
--
Jonathan