netdev - Re: [PATCH AUTOSEL 4.9 11/16] net: korina: Fix return type of korina_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221017102503.GA15612@duo.ucw.cz>
Date:   Mon, 17 Oct 2022 12:25:03 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Nathan Huckleberry <nhuck@...gle.com>,
        Dan Carpenter <error27@...il.com>, llvm@...ts.linux.dev,
        Nathan Chancellor <nathan@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, ndesaulniers@...gle.com,
        mkl@...gutronix.de, thomas.lendacky@....com, khalasa@...p.pl,
        wsa+renesas@...g-engineering.com, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.9 11/16] net: korina: Fix return type of
 korina_send_packet

Hi!

> From: Nathan Huckleberry <nhuck@...gle.com>
> 
> [ Upstream commit 106c67ce46f3c82dd276e983668a91d6ed631173 ]
> 
> The ndo_start_xmit field in net_device_ops is expected to be of type
> netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
> 
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
> 
> The return type of korina_send_packet should be changed from int to
> netdev_tx_t.

Patches 4-6, 9-11: I see this is nice cleanup for mainline, but ... do
we have CFI in 4.9 tree? This mismatch does not and can not cause any
problems there, right?

Best regards,
								Pavel
--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)