lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Oct 2022 10:56:05 +0800 From: Guo Ren <guoren@...nel.org> To: Jakub Kicinski <kuba@...nel.org> Cc: andriy.shevchenko@...ux.intel.com, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, linux@...musvillemoes.dk, yury.norov@...il.com, caraitto@...gle.com, willemb@...gle.com, jonolson@...gle.com, amritha.nambiar@...el.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Guo Ren <guoren@...ux.alibaba.com>, Guenter Roeck <linux@...ck-us.net> Subject: Re: [PATCH] Revert "cpumask: fix checking valid cpu range" Ping Jakub Kicinski <kuba@...nel.org>. You seem to miss this Revert fixup on cpumask_check(n + 1). Your patch has merged in v6.1-rc1, but that is not enough. https://lore.kernel.org/netdev/166582921612.1299.769135677399153914.git-patchwork-notify@kernel.org/T/#m0111a76380626b2f91e072ecdd5827578d5cbf60 Without the patch, there still is a warning. On Sun, Oct 16, 2022 at 11:49 AM Guenter Roeck <linux@...ck-us.net> wrote: > > On 10/15/22 19:58, Guo Ren wrote: > > On Sun, Oct 16, 2022 at 12:50 AM Guenter Roeck <linux@...ck-us.net> wrote: > >> > >> On Sat, Oct 15, 2022 at 09:05:48AM -0400, guoren@...nel.org wrote: > >>> From: Guo Ren <guoren@...ux.alibaba.com> > >>> > >>> This reverts commit 78e5a3399421ad79fc024e6d78e2deb7809d26af. > >>> > >>> ------------[ cut here ]------------ > >>> WARNING: CPU: 3 PID: 1 at include/linux/cpumask.h:110 cpumask_next_wrap+0x5c/0x80 > >>> > >>> Let's back this out and retry with a larger clean up in -next. > >>> > >> > >> Unfortunately the revert triggers (or exposes ?) another backtrace. > > This should be fixed by another Revert patch. > > > > https://lore.kernel.org/netdev/166582921612.1299.769135677399153914.git-patchwork-notify@kernel.org/T/#m0111a76380626b2f91e072ecdd5827578d5cbf60 > > > > Please have a try. > > > > Yes, I already tested that one and confirmed that it fixes the warning below. > Thanks for the pointer. > > Guenter > > >> > >> WARNING: CPU: 0 PID: 1 at include/linux/cpumask.h:110 __netif_set_xps_queue+0x194/0x976 > >> Modules linked in: > >> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.0.0-12199-g277163563de8 #1 > >> Hardware name: riscv-virtio,qemu (DT) > >> epc : __netif_set_xps_queue+0x194/0x976 > >> ra : __netif_set_xps_queue+0x3b0/0x976 > >> epc : c089a664 ra : c089a880 sp : c2515c60 > >> gp : c1d8e760 tp : c2578040 t0 : c364f980 > >> t1 : 00000000 t2 : 00001fff s0 : c2515cd0 > >> s1 : c2515ce4 a0 : c364f940 a1 : 00000000 > >> a2 : c364f940 a3 : 00000000 a4 : c364f950 > >> a5 : c364f890 a6 : 00000003 a7 : 00000000 > >> s2 : 00000001 s3 : c1d382c0 s4 : 00000000 > >> s5 : 00000000 s6 : 00000000 s7 : c364f880 > >> s8 : 00000000 s9 : 00000001 s10: 00000001 > >> s11: 00000000 t3 : 00000018 t4 : 7fd38a0e > >> t5 : 00000007 t6 : c3639470 > >> status: 00000120 badaddr: 00000000 cause: 00000003 > >> [<c074548a>] virtnet_set_affinity+0x13a/0x1a2 > >> [<c07478de>] virtnet_probe+0x884/0xfdc > >> [<c063ce9a>] virtio_dev_probe+0x1d6/0x354 > >> [<c0683d6e>] really_probe+0x82/0x214 > >> [<c0683f58>] __driver_probe_device+0x58/0xa2 > >> [<c0683fd2>] driver_probe_device+0x30/0xaa > >> [<c0684596>] __driver_attach+0x56/0x11c > >> [<c0681f26>] bus_for_each_dev+0x52/0x90 > >> [<c06837c0>] driver_attach+0x1a/0x22 > >> [<c068331a>] bus_add_driver+0x148/0x1b6 > >> [<c0684d70>] driver_register+0x52/0xea > >> [<c063c924>] register_virtio_driver+0x1a/0x28 > >> [<c0c2428e>] virtio_net_driver_init+0x7a/0xa6 > >> [<c0002824>] do_one_initcall+0x5e/0x2e2 > >> [<c0c01130>] kernel_init_freeable+0x298/0x306 > >> [<c0aa0ac2>] kernel_init+0x1e/0x10e > >> [<c0003ad8>] ret_from_exception+0x0/0x10 > >> irq event stamp: 106012 > >> hardirqs last enabled at (106011): [<c0aa9284>] _raw_spin_unlock_irqrestore+0x54/0x62 > >> hardirqs last disabled at (106012): [<c0007534>] __trace_hardirqs_off+0xc/0x14 > >> softirqs last enabled at (105764): [<c0886392>] napi_get_frags_check+0x0/0x50 > >> softirqs last disabled at (105758): [<c0886392>] napi_get_frags_check+0x0/0x50 > >> > >> This is the result of commit 854701ba4c39 ("net: fix cpu_max_bits_warn() > >> usage in netif_attrmask_next{,_and}"). > >> > >> Guenter > > > > > > > -- Best Regards Guo Ren
Powered by blists - more mailing lists