netdev - Re: [PATCH v5 1/3] dt-bindings: net: marvell,pp2: convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPv3WKcCtORYd8Y-ouqoPSZWYY2OvSunsGVFycV6dzF5F4EzKA@mail.gmail.com>
Date:   Mon, 17 Oct 2022 14:52:36 +0200
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Michał Grzelak <mig@...ihalf.com>,
        davem@...emloft.net, krzysztof.kozlowski+dt@...aro.org,
        upstream@...ihalf.com, kuba@...nel.org, edumazet@...gle.com,
        netdev@...r.kernel.org, pabeni@...hat.com,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux@...linux.org.uk
Subject: Re: [PATCH v5 1/3] dt-bindings: net: marvell,pp2: convert to json-schema

pon., 17 paź 2022 o 00:58 Rob Herring <robh@...nel.org> napisał(a):
>
> On Fri, 14 Oct 2022 23:32:52 +0200, Michał Grzelak wrote:
> > Convert the marvell,pp2 bindings from text to proper schema.
> >
> > Move 'marvell,system-controller' and 'dma-coherent' properties from
> > port up to the controller node, to match what is actually done in DT.
> >
> > Rename all subnodes to match "^(ethernet-)?port@[0-2]$" and deprecate
> > port-id in favour of 'reg'.
> >
> > Signed-off-by: Michał Grzelak <mig@...ihalf.com>
> > ---
> >  .../devicetree/bindings/net/marvell,pp2.yaml  | 305 ++++++++++++++++++
> >  .../devicetree/bindings/net/marvell-pp2.txt   | 141 --------
> >  MAINTAINERS                                   |   2 +-
> >  3 files changed, 306 insertions(+), 142 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/net/marvell,pp2.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/net/marvell-pp2.txt
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> ethernet@0: 'eth0', 'eth1', 'eth2' do not match any of the regexes: '^(ethernet-)?port@[0-2]$', 'pinctrl-[0-9]+'
>         arch/arm64/boot/dts/marvell/armada-7040-db.dtb
>         arch/arm64/boot/dts/marvell/armada-7040-mochabin.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-db.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-db.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dtb
>         arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dtb
>         arch/arm64/boot/dts/marvell/cn9130-crb-A.dtb
>         arch/arm64/boot/dts/marvell/cn9130-crb-B.dtb
>         arch/arm64/boot/dts/marvell/cn9130-db-B.dtb
>         arch/arm64/boot/dts/marvell/cn9130-db.dtb
>         arch/arm64/boot/dts/marvell/cn9131-db-B.dtb
>         arch/arm64/boot/dts/marvell/cn9131-db-B.dtb
>         arch/arm64/boot/dts/marvell/cn9131-db.dtb
>         arch/arm64/boot/dts/marvell/cn9131-db.dtb
>         arch/arm64/boot/dts/marvell/cn9132-db-B.dtb
>         arch/arm64/boot/dts/marvell/cn9132-db-B.dtb
>         arch/arm64/boot/dts/marvell/cn9132-db-B.dtb
>         arch/arm64/boot/dts/marvell/cn9132-db.dtb
>         arch/arm64/boot/dts/marvell/cn9132-db.dtb
>         arch/arm64/boot/dts/marvell/cn9132-db.dtb
>
> ethernet@...00: 'eth0', 'eth1' do not match any of the regexes: '^(ethernet-)?port@[0-2]$', 'pinctrl-[0-9]+'
>         arch/arm/boot/dts/armada-375-db.dtb
>

These warnings are addressed by the other 2 patches in this patchset:
[PATCH v5 2/3] arm64: dts: marvell: Update network description to match schema
[PATCH v5 3/3] ARM: dts: armada-375: Update network description to match schema

Can you please re-run check in your setup with the above applied?

Best regards,
Marcin