lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 17 Oct 2022 11:02:45 -0300
From:   "Guilherme G. Piccoli" <>
        Sergei Shtylyov <>
Subject: Re: [PATCH V3 06/11] tracing: Improve panic/die notifiers

On 19/08/2022 19:17, Guilherme G. Piccoli wrote:
> Currently the tracing dump_on_oops feature is implemented through
> separate notifiers, one for die/oops and the other for panic;
> given they have the same functionality, let's unify them.
> Also improve the function comment and change the priority of the
> notifier to make it execute earlier, avoiding showing useless trace
> data (like the callback names for the other notifiers); finally,
> we also removed an unnecessary header inclusion.
> Cc: Petr Mladek <>
> Cc: Sergei Shtylyov <>
> Cc: Steven Rostedt <>
> Signed-off-by: Guilherme G. Piccoli <>
> ---
> V3:
> - Removed goto usage, as per Steven suggestion (thanks!).
> V2:
> - Different approach; instead of using IDs to distinguish die and
> panic events, rely on address comparison like other notifiers do
> and as per Petr's suggestion;
> - Removed ACK from Steven since the code changed.

Hi Steven, apologies for the re-ping. Is there anything else to do in
this one, or do you think it's good enough?



Powered by blists - more mailing lists