netdev - Re: [PATCH net-next 2/4] selftests: bridge_igmp: Remove unnecessary address deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b22a460d-88bb-f159-c75a-acd635430167@blackwall.org>
Date:   Tue, 18 Oct 2022 11:37:16 +0300
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, roopa@...dia.com, mlxsw@...dia.com
Subject: Re: [PATCH net-next 2/4] selftests: bridge_igmp: Remove unnecessary
 address deletion

On 18/10/2022 09:39, Ido Schimmel wrote:
> The test group address is added and removed in v2reportleave_test().
> There is no need to delete it again during cleanup as it results in the
> following error message:
> 
>  # bash -x ./bridge_igmp.sh
>  [...]
>  + cleanup
>  + pre_cleanup
>  [...]
>  + ip address del dev swp4 239.10.10.10/32
>  RTNETLINK answers: Cannot assign requested address
>  + h2_destroy
> 
> Solve by removing the unnecessary address deletion.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  tools/testing/selftests/net/forwarding/bridge_igmp.sh | 3 ---
>  1 file changed, 3 deletions(-)

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>