netdev - Re: [PATCH v3 net] udp: Update reuse->has_conns under reuseport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 09:00:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Kuniyuki Iwashima <kuniyu@...zon.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        martin.lau@...nel.org, kraig@...gle.com, willemb@...gle.com,
        kuni1840@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 net] udp: Update reuse->has_conns under reuseport_lock.

Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@...hat.com>:

On Fri, 14 Oct 2022 11:26:25 -0700 you wrote:
> When we call connect() for a UDP socket in a reuseport group, we have
> to update sk->sk_reuseport_cb->has_conns to 1.  Otherwise, the kernel
> could select a unconnected socket wrongly for packets sent to the
> connected socket.
> 
> However, the current way to set has_conns is illegal and possible to
> trigger that problem.  reuseport_has_conns() changes has_conns under
> rcu_read_lock(), which upgrades the RCU reader to the updater.  Then,
> it must do the update under the updater's lock, reuseport_lock, but
> it doesn't for now.
> 
> [...]

Here is the summary with links:
  - [v3,net] udp: Update reuse->has_conns under reuseport_lock.
    https://git.kernel.org/netdev/net/c/69421bf98482

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html