netdev - Re: [PATCH AUTOSEL 5.10 22/34] net/sched: taprio: taprio_dump and taprio_change are protected by rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221018094653.nt4sh67m2mjkcnkv@skbuf>
Date:   Tue, 18 Oct 2022 09:46:54 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Pavel Machek <pavel@...x.de>
CC:     Sasha Levin <sashal@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.10 22/34] net/sched: taprio: taprio_dump and
 taprio_change are protected by rtnl_mutex

On Tue, Oct 18, 2022 at 11:44:15AM +0200, Pavel Machek wrote:
> Hi!
> 
> > From: Vladimir Oltean <vladimir.oltean@....com>
> > 
> > [ Upstream commit 18cdd2f0998a4967b1fff4c43ed9aef049e42c39 ]
> > 
> > Since the writer-side lock is taken here, we do not need to open an RCU
> > read-side critical section, instead we can use rtnl_dereference() to
> > tell lockdep we are serialized with concurrent writes.
> 
> This is cleanup, not a bugfix. We should not have it in 5.10.

Agreed, looks like I missed this one when replying to Sasha for all the others.