netdev - Re: [PATCH net-next] ibmveth: Always stop tx queues during close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 11:47:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Nick Child <nnac123@...ux.ibm.com>
Cc:     netdev@...r.kernel.org, nick.child@....com
Subject: Re: [PATCH net-next] ibmveth: Always stop tx queues during close

On Mon, 17 Oct 2022 10:17:43 -0500 Nick Child wrote:
> The issue with this approach was that the hypervisor freed all of
> the devices control structures after the hcall H_FREE_LOGICAL_LAN
> was performed but the transmit queues were never stopped. So the higher
> layers in the network stack would continue transmission but any
> H_SEND_LOGICAL_LAN hcall would fail with H_PARAMETER until the
> hypervisor's structures for the device were allocated with the
> H_REGISTER_LOGICAL_LAN hcall in ibmveth_open.

Sounds like we should treat this one as a fix as well?
How far back is it safe to backport?