netdev - Re: [PATCH net] ip6mr: fix UAF issue in ip6mr_sk_done() when addrconf_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLHJpzXUQD+NUrfyuSJbzpV9B2eEj54Um4f+bkAjMVWOg@mail.gmail.com>
Date:   Mon, 17 Oct 2022 20:35:16 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     shaozhengchao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org,
        pabeni@...hat.com, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net] ip6mr: fix UAF issue in ip6mr_sk_done() when
 addrconf_init_net() failed

On Mon, Oct 17, 2022 at 7:33 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Mon, Oct 17, 2022 at 6:48 PM shaozhengchao <shaozhengchao@...wei.com> wrote:

> > Hi Eric:
> >         Thank you for your reply. I wonder if fixing commit
> > e0da5a480caf ("[NETNS]: Create ipv6 devconf-s for namespaces")
> > would be more appropriate?
>
> Do you have a repro ?
>
> You could first use scripts/decode_stack.pl to get symbols from your
> traces, to confirm the issue.
>

Hmm... I read again the stack traces, and while addrconf_exit_net() is
not called,
igmp6_net_exit() _is_ called, so I guess your patch is fine, thanks !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>