lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Oct 2022 09:24:15 +0530 From: sundeep subbaraya <sundeep.lkml@...il.com> To: Manank Patel <pmanank200502@...il.com> Cc: sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com, hkelam@...vell.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ethernet: marvell: octeontx2 Fix resource not freed after malloc Hi, On Tue, Oct 18, 2022 at 1:27 AM Manank Patel <pmanank200502@...il.com> wrote: > > fix rxsc not getting freed before going out of scope > > Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading") > > Signed-off-by: Manank Patel <pmanank200502@...il.com> > --- > drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c > index 9809f551fc2e..c7b2ebb2c75b 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c > @@ -870,6 +870,7 @@ static struct cn10k_mcs_rxsc *cn10k_mcs_create_rxsc(struct otx2_nic *pfvf) > cn10k_mcs_free_rsrc(pfvf, MCS_RX, MCS_RSRC_TYPE_FLOWID, > rxsc->hw_flow_id, false); > fail: > + kfree(rxsc); Thanks for the fix. Can you do the same in cn10k_mcs_create_txsc as well. Sundeep > return ERR_PTR(ret); > } > > -- > 2.38.0 >
Powered by blists - more mailing lists