netdev - Re: [PATCH net-next 2/4] net: move add ct helper function to nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 12:18:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>, dev@...nvswitch.org,
        ovs-dev@...nvswitch.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, kuba@...nel.org,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Pravin B Shelar <pshelar@....org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Oz Shlomo <ozsh@...dia.com>, Paul Blakey <paulb@...dia.com>,
        Ilya Maximets <i.maximets@....org>,
        Eelco Chaudron <echaudro@...hat.com>,
        Aaron Conole <aconole@...hat.com>
Subject: Re: [PATCH net-next 2/4] net: move add ct helper function to
 nf_conntrack_helper for ovs and tc

Hi Xin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Xin-Long/net-add-helper-support-in-tc-act_ct-for-ovs-offloading/20221018-033308
patch link:    https://lore.kernel.org/r/5957a293eadac6403657d079ddc6e360cd3f0895.1666034595.git.lucien.xin%40gmail.com
patch subject: [PATCH net-next 2/4] net: move add ct helper function to nf_conntrack_helper for ovs and tc
config: x86_64-randconfig-c002-20221017
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/b3a27f00504b57dc9a4c585494314b47398e7bb0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Xin-Long/net-add-helper-support-in-tc-act_ct-for-ovs-offloading/20221018-033308
        git checkout b3a27f00504b57dc9a4c585494314b47398e7bb0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/netfilter/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/netfilter/nf_conntrack_helper.c: In function 'nf_ct_add_helper':
>> net/netfilter/nf_conntrack_helper.c:319:13: warning: unused variable 'err' [-Wunused-variable]
     319 |         int err;
         |             ^~~


vim +/err +319 net/netfilter/nf_conntrack_helper.c

   313	
   314	int nf_ct_add_helper(struct nf_conn *ct, const char *name, u8 family,
   315			     u8 proto, bool nat, struct nf_conntrack_helper **hp)
   316	{
   317		struct nf_conntrack_helper *helper;
   318		struct nf_conn_help *help;
 > 319		int err;
   320	
   321		helper = nf_conntrack_helper_try_module_get(name, family, proto);
   322		if (!helper)
   323			return -EINVAL;
   324	
   325		help = nf_ct_helper_ext_add(ct, GFP_KERNEL);
   326		if (!help) {
   327			nf_conntrack_helper_put(helper);
   328			return -ENOMEM;
   329		}
   330	#if IS_ENABLED(CONFIG_NF_NAT)
   331		if (nat) {
   332			err = nf_nat_helper_try_module_get(name, family, proto);
   333			if (err) {
   334				nf_conntrack_helper_put(helper);
   335				return err;
   336			}
   337		}
   338	#endif
   339		rcu_assign_pointer(help->helper, helper);
   340		*hp = helper;
   341		return 0;
   342	}
   343	EXPORT_SYMBOL_GPL(nf_ct_add_helper);
   344	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (136106 bytes)