netdev - Re: [PATCH v3 net] net: ftmac100: support frames with DSA tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221019140239.hboqna4lugwmnwph@skbuf>
Date:   Wed, 19 Oct 2022 17:02:39 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Sergei Antonov <saproj@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v3 net] net: ftmac100: support frames with DSA tag

On Wed, Oct 19, 2022 at 04:57:05PM +0300, Sergei Antonov wrote:
> > Which VLAN tag do you mean? Earlier you mentioned a tail tag as can be
> > seen and parsed by net/dsa/tag_trailer.c. Don't conflate the two, one
> > has nothing to do with the other.
> 
> I used print_hex_dump_bytes() in the ftmac100 driver to see what is
> inside the received packet. Here is how the 1518 byte long packet
> looks:
> 6 bytes - dst MAC
> 6 bytes - src MAC
> 4 bytes - 08 00 45 10
> 2 bytes - 0x5dc - data length (1500)
> 1500 bytes - data
> 
> I am not sure what is the proper name for these 08 00 45 10 bytes.
> Tell me the correct name to use in the next version of the patch :).

Humm, how about IPv4 EtherType (08 00) plus the first 2 bytes from the
IPv4 header? 802.1Q EtherType is 0x8100.